Seal of Vengeance/Corruption

bump...

swt lah iklan sebelah ini T_T >>>>>>>>>>>
jadi berantakan code nya, post di bawah ini, sorry doble post

nemu juga mirip (atau munkgin emang sumber sama) dari punya totonk di halaman sebelumnya, sapa tau bisa bantu

Code:

---

// Seal of Vengeance (damage calc on apply aura)
case 31801:
{
        if (effIndex != 0)                    // effect 1,2 used by seal unleashing code
                return false;


        // At melee attack or Hammer of the Righteous spell damage considered as melee attack
        if ((procFlag & PROC_FLAG_SUCCESSFUL_MELEE_HIT) || (procSpell && procSpell->Id == 53595))
                triggered_spell_id = 31803;
        // On target with 5 stacks of Holy Vengeance direct damage is done
        if (Aura * aur = pVictim->GetAura(triggered_spell_id, GetGUID()))
        {
                if (aur->GetStackAmount() == 5)
                {
                        aur->RefreshDuration();
                        CastSpell(pVictim, 42463, true);
                        return true;
                }
        }

        // Only Autoattack can stack debuff
        if (procFlag & PROC_FLAG_SUCCESSFUL_MELEE_SPELL_HIT)
                return false;
                break;
        }

// Seal of Corruption
case 53736:
{
        if (effIndex != 0)                // effect 1,2 used by seal unleashing code
                return false;


        // At melee attack or Hammer of the Righteous spell damage considered as melee attack
        if ((procFlag & PROC_FLAG_SUCCESSFUL_MELEE_HIT) || (procSpell && procSpell->Id == 53595))
                triggered_spell_id = 53742;
        // On target with 5 stacks of Blood Corruption direct damage is done
        if (Aura * aur = pVictim->GetAura(triggered_spell_id, GetGUID()))
        {
                if (aur->GetStackAmount() == 5)
                {
                        aur->RefreshDuration();
                        CastSpell(pVictim, 53739, true);
                        return true;
                }
        }

        // Only Autoattack can stack debuff
        if (procFlag & PROC_FLAG_SUCCESSFUL_MELEE_SPELL_HIT)
                return false;
                break;       
}

---

(eh itu kurung kurawal terakhir ga terlalu kelihatan, aneh di apa2in ga bisa biar kelihatan, klo di copy jngn ketinngalan y ^^)
dari http://code.google.com/p/dws-core/so...278a9357a043db

klo ternyata udah gitu, mungkin (mungkin nih, ga tau source nya kyk gmna), crusader strike dan divine storm blm di anggep melee strike, jadi ga bisa di keluarin trigger seal corruption/vengeance

wah lebih mantep lagi nih codenya,,moga2 aj ada GM sudi mampir/ngasih tanggapan T-T

moga2 maintenance minggu ini dah bener SoV

bump... blm juga di benerin T_T

saran lagi, gmna klo spell id nya crusader strike dan divine storm di mskin ke clausa if buat trigger procnya?

Code:

---

if ((procFlag & PROC_FLAG_SUCCESSFUL_MELEE_HIT) || (procSpell && procSpell->Id == 53595))
                triggered_spell_id = 31803;

---

jadi misal hasilnya

Code:

---

if ((procFlag & PROC_FLAG_SUCCESSFUL_MELEE_HIT) || (procSpell && procSpell->Id == 53595) || (procSpell && procSpell->Id == x) || (procSpell && procSpell->Id == y))
                triggered_spell_id = 31803;

---

dengan x id nya crusader strike, dan y id nya divine storm

up..up..
segera dibenerin plz..ga sabar liat dps pake SoV

Iya,berharap di fix ini,2x icc,pake seal sor dps 19,2k di saurfang,pas ganti socrr pas next icc,19,3k....andaikan udah di fix,pally menguasai dps ni di raid...kalo blm di fix juga,terpaksa de masih pake t9 terus ,lol

abis ubek2 codetrackernya tirinity nemu lagi
dari https://github.com/TrinityCore/TrinityCore/issues/1461

Link Source klo mau lihat lebih enak

Code:

---

@@ -6700,22 +6700,28 @@ bool Unit::HandleDummyAuraProc(Unit *pVictim, uint32 damage, AuraEffect* trigger
        if (effIndex != 0)                      // effect 1, 2 used by seal unleashing code
                return false;
 
-        // At melee attack or Hammer of the Righteous spell damage considered as melee attack
-        if ((procFlag & PROC_FLAG_DONE_MELEE_AUTO_ATTACK) || (procSpell && procSpell->Id == 53595))
+        // Auto attack, Hammer of the Righteous
+        bool stacker = ((procFlag & PROC_FLAG_DONE_MELEE_AUTO_ATTACK) || (procSpell && procSpell->Id == 53595));
+        // Divine Storm, Crusader Strike
+        bool damager = ((procSpell && procSpell->Id == 53385) || (procSpell && procSpell->Id == 35395));
+
+        // Only proc melee attacks
+        if (stacker || damager)
                triggered_spell_id = 31803;
        // On target with 5 stacks of Holy Vengeance direct damage is done
        if (Aura * aur = pVictim->GetAura(triggered_spell_id, GetGUID()))
        {
                if (aur->GetStackAmount() == 5)
                {
-                        aur->RefreshDuration();
+                        if (stacker)
+                                aur->RefreshDuration();
                        CastSpell(pVictim, 42463, true);
                        return true;
                }
        }
 
-        // Only Autoattack can stack debuff
-        if (procFlag & PROC_FLAG_DONE_SPELL_MELEE_DMG_CLASS)
+        // Only Autoattack and Hammer of the Righteous can stack debuff
+        if (!stacker)
                return false;
        break;
}

@@ -6725,22 +6731,28 @@ bool Unit::HandleDummyAuraProc(Unit *pVictim, uint32 damage, AuraEffect* trigger
        if (effIndex != 0)                      // effect 1, 2 used by seal unleashing code
                return false;
 
-        // At melee attack or Hammer of the Righteous spell damage considered as melee attack
-        if ((procFlag & PROC_FLAG_DONE_MELEE_AUTO_ATTACK) || (procSpell && procSpell->Id == 53595))
+        // Auto attack, Hammer of the Righteous
+        bool stacker = ((procFlag & PROC_FLAG_DONE_MELEE_AUTO_ATTACK) || (procSpell && procSpell->Id == 53595));
+        // Divine Storm, Crusader Strike
+        bool damager = ((procSpell && procSpell->Id == 53385) || (procSpell && procSpell->Id == 35395));
+
+        // Only proc melee attacks
+        if (stacker || damager)
                triggered_spell_id = 53742;
        // On target with 5 stacks of Blood Corruption direct damage is done
        if (Aura * aur = pVictim->GetAura(triggered_spell_id, GetGUID()))
        {
                if (aur->GetStackAmount() == 5)
                {
-                        aur->RefreshDuration();
+                        if (stacker)
+                                aur->RefreshDuration();
                        CastSpell(pVictim, 53739, true);
                        return true;
                }
        }
 
-        // Only Autoattack can stack debuff
-        if (procFlag & PROC_FLAG_DONE_SPELL_MELEE_DMG_CLASS)
+        // Only Autoattack and Hammer of the Righteous can stack debuff
+        if (!stacker)
                return false;
        break;
}

---

yg ada tanda - line yg di hapus dari source awal yg di server skrng
yg ada tanda + source tambahan buat benerin

bantu bump ini thread :),semoga bisa di fix talent sov/socrrnya

bump di hari ke-x. . . .

semoga dilirik,setelah dilirik,di fix.Amin :lol:

ok dah bener ^^

thanks a lot buat GM nya

bump bump,btw udah bener?kok pas gw test di dummy,itu sealnya masih sama de keknya kek dulu. . . .


*EDIT+RALAT

UDAH BENER :),sorry2 salah liat

Udh bener skr skill seal of corruption nya kk?

Skalian mu tanya, heart of the crusade itu emg error ya skr? ga ada nambahin 3%crit nya?

ohhh ternyata masi bug to.. ampe 50% ya...
.
cpt cpt di fix de ini termasuk major bug
.
btw di ally populasi pally bejibun lohhh....... di horde jg banyak tapi gak sebanyak ally
.
pasti cepet di fix....

Quote:

---

Originally Posted by fullcream

ohhh ternyata masi bug to.. ampe 50% ya...
.
cpt cpt di fix de ini termasuk major bug
.
btw di ally populasi pally bejibun lohhh....... di horde jg banyak tapi gak sebanyak ally
.
pasti cepet di fix....

---

eh sooryy udh bener lagi ya...????
.