Unofficial Bug Fixing

[gaptekbet]

upload diff/patch file nya aja pin biar gak repot GM-nya, kasian nyari line2 nya pake editor di console

[--Miakis--]

kmaren dah post link buat set t10 beberapa class cuma mungkin blum di tes ama GM,
klo bisa bro heaven silahkan tes
Warrior T10 Melee 4P Bonus
Druid T10 Balance 2P Bonus
Druid T10 Feral 4P Bonus
Priest T10 Healer 4P Bonus
Druid T10 Balance 4P Bonus
Paladin T10 Retribution 2P Bonus
Shaman T10 Restoration 4P Bonus
Shaman T9 Elemental 4P Bonus
Shaman T10 Elemental 4P Bonus
Rogue T10 2P Bonus
Death Knight T10 Melee 4P Bonus

hmm ini ya?

Spoiler untuk hmm :

diff -r 396488cf587f -r e051f6434b01 sql/spell_proc_event.sql
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/sql/spell_proc_event.sql Tue Apr 27 00:44:47 2010 +0300
@@ -0,0 +1,11 @@
+DELETE FROM `spell_proc_event` WHERE `entry` IN (70799,70808,70817,70723,70805,70803,70854);
+INSERT INTO `spell_proc_event`
+(`entry`,`SchoolMask`,`SpellFamilyName`,`SpellFamilyMask0`,`SpellFamilyMask1`,`SpellFamilyMask2`,`procFlags`,`procEx`,`ppmRate`,`CustomChance`,`Cooldown`) VALUES
+(70799,0,6,0x00000800,0,0,0,0,0,0,0), -- Priest T10 Healer 4P Bonus
+(70808,0,11,0x00000100,0,0,0,2,0,0,0), -- Shaman T10 Restoration 4P Bonus
+(70817,0,11,0,0x00001000,0,0x00010000,0,0,0,0), -- Shaman T10 Elemental 4P Bonus
+(70723,0,7,0x00000005,0,0,0,2,0,0,0), -- Druid T10 Balance 4P Bonus
+(70805,0,8,0,0x00020000,0,0x00004000,0,0,0,0), -- Rogue T10 2P Bonus
+(70803,0,8,4063232,0,0,0,0,0,0,0), -- Rogue T10 4P Bonus
+(70854,0,5,0,0x00000010,0,0,0,0,0,0); -- Warrior T10 Melee 2P Bonus
\ No newline at end of file
diff -r 396488cf587f -r e051f6434b01 src/game/SpellEffects.cpp
--- a/src/game/SpellEffects.cpp Mon Apr 26 22:22:34 2010 +0300
+++ b/src/game/SpellEffects.cpp Tue Apr 27 00:44:47 2010 +0300
@@ -1790,7 +1790,7 @@
// Last Stand
case 12975:
{
- int32 healthModSpellBasePoints0 = int32(m_caster->GetMaxHealth()*0.3);
+ int32 healthModSpellBasePoints0 = int32(m_caster->GetMaxHealth() * 0.3);
m_caster->CastCustomSpell(m_caster, 12976, &healthModSpellBasePoints0, NULL, NULL, true, NULL);
return;
}
@@ -1851,6 +1851,11 @@
SendCastResult(SPELL_FAILED_FIZZLE);
return;
}
+ // Item - Warrior T10 Melee 4P Bonus
+ if (m_spellInfo->Id == 46916 || m_spellInfo->Id == 52437)
+ if (Aura * aur = m_caster->GetAura(70847))
+ if (roll_chance_i(20))
+ m_caster->CastSpell(m_caster, 70849, true);
break;
case SPELLFAMILY_PRIEST:
// Penance
@@ -1897,6 +1902,14 @@
m_caster->CastSpell(unitTarget, damage, true);
return;
}
+ // Item - Druid T10 Balance 2P Bonus
+ if (m_spellInfo->Id == 16870 && m_caster->HasAura(70718))
+ m_caster->CastSpell(m_caster, 70721, true);
+
+ // Item - Druid T10 Feral 4P Bonus
+ if (m_spellInfo->Id == 5229 && m_caster->HasAura(70726))
+ m_caster->CastSpell(m_caster, 70725, true);
+
break;
case SPELLFAMILY_ROGUE:
// Hunger for Blood
diff -r 396488cf587f -r e051f6434b01 src/game/Unit.cpp
--- a/src/game/Unit.cpp Mon Apr 26 22:22:34 2010 +0300
+++ b/src/game/Unit.cpp Tue Apr 27 00:44:47 2010 +0300
@@ -6300,6 +6300,19 @@
triggered_spell_id = 28810;
break;
}
+ // Item - Priest T10 Healer 4P Bonus
+ case 70799:
+ {
+ if (GetTypeId() != TYPEID_PLAYER)
+ return false;
+
+ // Circle of Healing
+ this->ToPlayer()->RemoveSpellCategoryCooldown(1204, true);
+ // Penance
+ this->ToPlayer()->RemoveSpellCategoryCooldown(1230, true);
+
+ return true;
+ }
}
break;
}
@@ -6379,6 +6392,14 @@
triggered_spell_id = 54755;
break;
}
+ // Item - Druid T10 Balance 4P Bonus
+ case 70723:
+ {
+ basepoints0 = int32(triggerAmount * damage / 100);
+ basepoints0 = int32(basepoints0 / 2);
+ triggered_spell_id = 71023;
+ break;
+ }
// Healing Touch Refund (Idol of Longevity trinket)
case 28847:
{
@@ -6911,6 +6932,15 @@
basepoints0 = triggerAmount*damage/100;
break;
}
+ // Item - Paladin T10 Retribution 2P Bonus
+ case 70765:
+ {
+ if (GetTypeId() != TYPEID_PLAYER)
+ return false;
+
+ this->ToPlayer()->RemoveSpellCooldown(53385, true);
+ return true;
+ }
}
break;
}
@@ -7114,18 +7144,38 @@
// Shaman T8 Elemental 4P Bonus
case 64928:
{
- basepoints0 = int32(triggerAmount * damage / 100);
+ basepoints0 = int32(basepoints0 / 2);
triggered_spell_id = 64930; // Electrified
break;
}
- }
- // Shaman T9 Elemental 4P Bonus - Wrong need recheck target and avoid wrong triggers
- /*case 67228:
- {
- basepoints0 = int32( triggerAmount * damage / 100 );
- triggered_spell_id = 71824;
- break;
- }*/
+ // Shaman T9 Elemental 4P Bonus
+ case 67228:
+ {
+ basepoints0 = int32(basepoints0 / 3); // basepoints is for 1 tick, not the entire DoT amount
+ triggered_spell_id = 71824;
+ break;
+ }
+ // Item - Shaman T10 Restoration 4P Bonus
+ case 70808:
+ {
+ basepoints0 = int32( triggerAmount * damage / 100 );
+ basepoints0 = int32( basepoints0 / 3); // basepoints is for 1 tick, not all DoT amount
+ triggered_spell_id = 70809;
+ break;
+ }
+ // Item - Shaman T10 Elemental 4P Bonus
+ case 70817:
+ {
+ if (AuraEffect const * aura = pVictim->GetAuraEffect(SPELL_AURA_PERIODIC_DAMAGE, SPELLFAMILY_SHAMAN, 0x10000000, 0, 0))
+ {
+ int32 amount = aura->GetBase()->GetDuration() + triggerAmount * IN_MILISECONDS;
+ aura->GetBase()->SetDuration(amount);
+ //aura->SendAuraUpdate(false);
+ return true;
+ }
+ return false;
+ }
+ }
// Frozen Power
if (dummySpell->SpellIconID == 3780)
{
@@ -7492,6 +7542,16 @@
triggered_spell_id = 50526;
break;
}
+ // Item - Death Knight T10 Melee 4P Bonus
+ else if (dummySpell->Id == 70656)
+ {
+ if (GetTypeId() != TYPEID_PLAYER)
+ return false;
+
+ for (uint32 i = 0; i < MAX_RUNES; ++i)
+ if (this->ToPlayer()->GetRuneCooldown(i) == 0)
+ return false;
+ }
// Sudden Doom
if (dummySpell->SpellIconID == 1939 && GetTypeId() == TYPEID_PLAYER)
{
@@ -8047,6 +8107,16 @@
}
break;
}
+ case SPELLFAMILY_ROGUE:
+ {
+ // Item - Rogue T10 2P Bonus
+ if (auraSpellInfo->Id == 70805)
+ {
+ if (pVictim != this)
+ return false;
+ }
+ break;
+ }
case SPELLFAMILY_HUNTER:
{
if (auraSpellInfo->SpellIconID == 3247) // Piercing Shots

Warrior meele 4pc
Dk meele 4pc

Ngak Jalan

[gaptekbet]

kk, server kita pake trinitycore. walaupun trinity itu "turunan" mangos tapi gak semua script mangos support di trinity. Yg kk kasih itu scriptnya mangos.

[--Miakis--]

kk, server kita pake trinitycore. walaupun trinity itu "turunan" mangos tapi gak semua script mangos support di trinity. Yg kk kasih itu scriptnya mangos.

ooh ok Thx kk..
ntar di cari lagi..
btw cara cari tw perbedaan nya gmna ya?

[tyo07]

perbedaan utama dari mangos dan trinity diliat darimananya bang?jangan2 bnyk script yang gua coba sbnrnya di mangos lg..

[mawanmawan]

perbedaan utama dari mangos dan trinity diliat darimananya bang?jangan2 bnyk script yang gua coba sbnrnya di mangos lg..

yap bener bnget,
butuh pencerahan nih om gaptekbet, kita sebagai orang awam kan klo mw bantu2 fix bug resourcenya terbatas ^^

[gaptekbet]

liat di public struct nya kalo dia mangil MaNGOS brarti punya MaNGOS. Sebenernya yg diperlukan sih tau logika scriptnya aja. Kalo masalah struktur bisa di rename asal bukan yg krusial aja, saya kasih hint aja nih kalo mau bantu scriptnya anub tolong dibaca2 file scriptnya cari yg dia spawn tribute chestnya, biasanya di declare di variable2 atas, contoh :

enumBlablabla
(
TributeChest = xxxxx
.....
.....
)

trus kalo nemu ada gituan, lihat ujung bawah2nya cari baris/line yg make variable tsb. kalo ada post aja disini.

BTW bola2 di twin masih suka nyemplung gak? kalo masih tolong GM nya ganti konstanta :

Position energiesSpawns[20]         =
{
    //lewy gorny
    { 516.120850, 153.876724, 395.257050, 5.947426 },
    { 520.381531, 163.129730, 395.257721, 5.857108 },
    { 524.978210, 170.881180, 395.257721, 5.735374 },
    { 533.405457, 179.017960, 395.255463, 5.275928 },
    { 545.795288, 179.278381, 395.257690, 4.910729 },
    //prawy gorny
    { 585.779724, 178.406448, 395.257477, 4.368811 },
    { 593.253479, 174.178940, 394.803131, 4.129275 },
    { 599.540405, 167.275803, 395.258484, 3.713021 },
    { 604.066467, 159.609192, 395.258484, 3.571659 },
    { 607.621155, 148.601044, 395.258545, 3.461709 },
    //lewy dolny
    { 607.049744, 126.789886, 395.260040, 2.730471 },
    { 600.815613, 113.664787, 395.258667, 2.596953 },
    { 593.267151, 105.430504, 395.258667, 2.290648 },
    { 583.886169, 99.776947, 395.258667, 2.188545 },
    { 572.608643, 94.870926, 395.260468, 1.776990 },
    //prawy dolny
    { 554.215271, 95.081627, 395.261047, 1.215430 },
    { 545.551514, 99.042221, 395.259644, 1.077986 },
    { 537.194580, 103.717400, 395.259674, 0.952322 },
    { 528.627991, 110.522202, 395.259827, 0.681359 },
    { 522.244507, 122.121460, 395.259827, 0.414324 }
};

kalo gak salah itu koordinat yg urutan ketiga (395.xxx) itu height nya jadi tinggal tambah/kurangin aja disesuaikan


untuk http://www.indogamers.com/showthread...=303028&page=3

bukannya tinggal add aja di table disenchant_loot_template? buat yg suka otak atik database/table mysql bisa bantu kok. Formatnya bisa lihat di http://www.trinitycore.info/index.php/Loot_template_tc2 dan untuk id item2nya dan chance nya bisa pake panduan wowhead

[mawanmawan]

klo misal script achieve leeroy ini gimana ?
dari ciri2 yg disebutin di atas gak ada sama skali - -a

Spoiler untuk leeroy patch :

diff -r 9ad0aaf0b0bb src/scripts/eastern_kingdoms/blackrock_spire/instance_blackrock_spire.cpp
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/src/scripts/eastern_kingdoms/blackrock_spire/instance_blackrock_spire.cpp Fri Mar 12 18:55:00 2010 +0100
@@ -0,0 +1,81 @@
+#include "ScriptedPch.h"
+#include "instance_blackrock_spire.h"
+
+struct instance_blackrock_spire : public ScriptedInstance
+{
+ instance_blackrock_spire(Map* pMap) : ScriptedInstance(pMap) {Initialize();};
+
+ uint32 leeroyTimer;
+ uint32 whelpCount;
+ uint32 leroyData;
+
+ bool leeeeeeeeroy;
+
+ void Initialize()
+ {
+ leeroyTimer = 15000;
+ whelpCount = 0;
+ leeeeeeeeroy = true;
+ leroyData = 0;
+ }
+
+ void SetData(uint32 type, uint32 data)
+ {
+ switch(type)
+ {
+ case EVENT_LEEEROY:
+ {
+ if(data == DONE)
+ DoCompleteAchievement(2188);
+ leroyData = data; break;
+ }
+ case WHELP_DEATH_COUNT:
+ {
+ if(data == 1){
+ SetData(EVENT_LEEEROY, IN_PROGRESS);
+ //DoSendNotifyToInstance("Leeeeeeeeeeeeeroy! Started");
+ }
+ whelpCount = data; break;
+ }
+ }
+ }
+
+ uint32 GetData(uint32 type)
+ {
+ switch(type)
+ {
+ case EVENT_LEEEROY: return leroyData;
+ case WHELP_DEATH_COUNT: return whelpCount;
+ }
+ }
+
+ void Update(uint32 diff)
+ {
+
+ if(GetData(EVENT_LEEEROY) != FAIL && GetData(EVENT_LEEEROY) == IN_PROGRESS){
+ if(leeroyTimer <= diff){
+ SetData(EVENT_LEEEROY, FAIL);
+ leeeeeeeeroy = false;
+ //DoSendNotifyToInstance("Leeeeeeeeeeeeeroy! Failed");
+ }else leeroyTimer -= diff;
+ if(whelpCount >= 50 && leeeeeeeeroy){
+ SetData(EVENT_LEEEROY, DONE);
+ //DoSendNotifyToInstance("Leeeeeeeeeeeeeroy! Success");
+ }
+ }
+ }
+};
+
+InstanceData* GetInstanceData_instance_blackrock_spire(Map* pMap)
+{
+ return new instance_blackrock_spire(pMap);
+}
+
+void AddSC_instance_blackrock_spire()
+{
+ Script *newscript;
+ newscript = new Script;
+ newscript->Name = "instance_blackrock_spire";
+ newscript->GetInstanceData = &GetInstanceData_instance_blackrock_spire;
+ newscript->RegisterSelf();
+}
diff -r 9ad0aaf0b0bb src/scripts/eastern_kingdoms/blackrock_spire/instance_blackrock_spire.h
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/src/scripts/eastern_kingdoms/blackrock_spire/instance_blackrock_spire.h Fri Mar 12 18:55:00 2010 +0100
@@ -0,0 +1,11 @@
+#ifndef DEF_BRS_H
+#define DEF_BRS_H
+
+enum iDefines
+{
+ EVENT_LEEEROY = 1,
+ WHELP_DEATH_COUNT = 2
+
+};
+
+#endif
diff -r 9ad0aaf0b0bb src/scripts/eastern_kingdoms/blackrock_spire/npc_whelp_plus_egg.cpp
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/src/scripts/eastern_kingdoms/blackrock_spire/npc_whelp_plus_egg.cpp Fri Mar 12 18:55:00 2010 +0100
@@ -0,0 +1,61 @@
+#include "ScriptedPch.h"
+#include "instance_blackrock_spire.h"
+
+struct npc_rookey_whelpAI : public ScriptedAI
+{
+ npc_rookey_whelpAI(Creature *c) : ScriptedAI(c) {
+ pInstance = c->GetInstanceData();
+ }
+
+ ScriptedInstance* pInstance;
+
+ void JustDied(Unit *who)
+ {
+ if (pInstance){
+ pInstance->SetData(WHELP_DEATH_COUNT, ((uint32)pInstance->GetData(WHELP_DEATH_COUNT)+1));
+ sLog.outError("zapocitavam whelpa");
+ }
+ }
+
+ void UpdateAI(const uint32 diff)
+ {
+ if (!UpdateVictim())
+ return;
+
+ DoMeleeAttackIfReady();
+ }
+
+};
+
+CreatureAI* GetAI_rookey_whelp(Creature* pCreature)
+{
+ return new npc_rookey_whelpAI(pCreature);
+}
+
+bool GOHello_rookey_egg(Player *pPlayer, GameObject *pGO)
+{
+ float x,y,z,o;
+ x = pPlayer->GetPositionX();
+ y = pPlayer->GetPositionY();
+ z = pPlayer->GetPositionZ();
+ o = pPlayer->GetOrientation();
+ pPlayer->SummonCreature(10161, x, y, z, o, TEMPSUMMON_TIMED_DESPAWN, 15000);
+ //destroy gobject need to be implemented
+
+ return true;
+};
+
+void AddSC_npc_rookey_whelp()
+{
+ Script *newscript;
+
+ newscript = new Script;
+ newscript->Name = "npc_rookey_whelp";
+ newscript->GetAI = &GetAI_rookey_whelp;
+ newscript->RegisterSelf();
+ newscript = new Script;
+
+ newscript->Name = "go_rookey_egg";
+ newscript->pGOHello = &GOHello_rookey_egg;
+ newscript->RegisterSelf();
+}
diff -r 9ad0aaf0b0bb src/game/ScriptLoader.cpp
--- a/src/game/ScriptLoader.cpp Sun Feb 14 06:05:41 2010 -0700
+++ b/src/game/ScriptLoader.cpp Fri Mar 12 18:57:51 2010 +0100
@@ -45,6 +45,8 @@
void AddSC_boss_tomb_of_seven();
void AddSC_instance_blackrock_depths();
void AddSC_boss_drakkisath(); //Blackrock Spire
+void AddSC_npc_rookey_whelp();
+void AddSC_instance_blackrock_spire();
void AddSC_boss_halycon();
void AddSC_boss_highlordomokk();
void AddSC_boss_mothersmolderweb();
@@ -509,6 +518,8 @@
AddSC_boss_tomb_of_seven();
AddSC_instance_blackrock_depths();
AddSC_boss_drakkisath(); //Blackrock Spire
+ AddSC_npc_rookey_whelp();
+ AddSC_instance_blackrock_spire();
AddSC_boss_halycon();
AddSC_boss_highlordomokk();
AddSC_boss_mothersmolderweb();
diff -r 9ad0aaf0b0bb src/scripts/CMakeLists.txt
--- a/src/scripts/CMakeLists.txt Sun Feb 14 06:05:41 2010 -0700
+++ b/src/scripts/CMakeLists.txt Fri Mar 12 18:57:33 2010 +0100
@@ -42,6 +42,9 @@
eastern_kingdoms/blackrock_spire/boss_shadow_hunter_voshgajin.cpp
eastern_kingdoms/blackrock_spire/boss_the_beast.cpp
eastern_kingdoms/blackrock_spire/boss_warmaster_voone.cpp
+ eastern_kingdoms/blackrock_spire/instance_blackrock_spire.cpp
+ eastern_kingdoms/blackrock_spire/instance_blackrock_spire.h
+ eastern_kingdoms/blackrock_spire/npc_whelp_plus_egg.cpp
eastern_kingdoms/blackwing_lair/boss_broodlord_lashlayer.cpp
eastern_kingdoms/blackwing_lair/boss_chromaggus.cpp
eastern_kingdoms/blackwing_lair/boss_ebonroc.cpp

[gaptekbet]

klo misal script achieve leeroy ini gimana ?
dari ciri2 yg disebutin di atas gak ada sama skali - -a

kayaknya sih aman, tapi patchnya mending manual dulu artinya masukin line nya satu2 jangan langsung pake command diff/patch sambil ngebandingin ada perbedaan gak di baris programnya

[sunlounger]

waduh, kalo file diffnya gw gak ada T_T, karena kalo patching selalu manual...lebih aman

[heaven1st]

Sorry , saya jarang2 buka forum kalo mau email aja k abang kopisusu aja , ntar dforward k saya hehe

FIx buat arena frame

 
battleground.cpp
		
426	426		                for (BattleGroundPlayerMap::const_iterator itr = GetPlayers().begin(); itr != GetPlayers().end(); ++itr)
427	427		                    if (Player *plr = objmgr.GetPlayer(itr->first))
428	428		                    {
429	+	                        // BG Status packet
430	+	                        WorldPacket status;
431	+	                        BattleGroundQueueTypeId bgQueueTypeId = BattleGroundMgr::BGQueueTypeId(m_TypeID, GetArenaType());
432	+	                        uint32 queueSlot = plr->GetBattleGroundQueueIndex(bgQueueTypeId);
433	+	                        sBattleGroundMgr.BuildBattleGroundStatusPacket(&status, this, queueSlot, STATUS_IN_PROGRESS, 0, GetStartTime(), GetArenaType());
434	+	                        plr->GetSession()->SendPacket(&status);
435	+	
429	436		                        plr->RemoveAurasDueToSpell(SPELL_ARENA_PREPARATION);
430	437		                        // remove auras with duration lower than 30s
431	438		                        Unit::AuraApplicationMap & auraMap = plr->GetAppliedAuras();
...			
1217	1224		    WorldPacket status;
1218	1225		    BattleGroundQueueTypeId bgQueueTypeId = BattleGroundMgr::BGQueueTypeId(m_TypeID, GetArenaType());
1219	1226		    uint32 queueSlot = plr->GetBattleGroundQueueIndex(bgQueueTypeId);
1220		-	    sBattleGroundMgr.BuildBattleGroundStatusPacket(&status, this, queueSlot, STATUS_IN_PROGRESS, 0, GetStartTime(), GetArenaType());
1227	+	    sBattleGroundMgr.BuildBattleGroundStatusPacket(&status, this, queueSlot, STATUS_IN_PROGRESS, 0, GetStartTime(), GetArenaType(), isArena() ? 0 : 1);
1221	1228		    plr->GetSession()->SendPacket(&status);
1222	1229		
1223	1230		    // add arena specific auras
...			
1251	1258		            plr->SetHealth(plr->GetMaxHealth());
1252	1259		            plr->SetPower(POWER_MANA, plr->GetMaxPower(POWER_MANA));
1253	1260		        }
1261	+	
1262	+	        WorldPacket teammate;
1263	+	        teammate.Initialize(SMSG_ARENA_OPPONENT_UPDATE, 8);
1264	+	        teammate << uint64(plr->GetGUID());
1265	+	        SendPacketToTeam(team, &teammate, plr, false);
1254	1266		    }
1255	1267		    else
1256	1268		    {


BattlegroundMgr.cpp

1249	1249		    }
1250	1250		}
1251	1251		
1252		-	void BattleGroundMgr::BuildBattleGroundStatusPacket(WorldPacket *data, BattleGround *bg, uint8 QueueSlot, uint8 StatusID, uint32 Time1, uint32 Time2, uint8 arenatype)
1252	+	void BattleGroundMgr::BuildBattleGroundStatusPacket(WorldPacket *data, BattleGround *bg, uint8 QueueSlot, uint8 StatusID, uint32 Time1, uint32 Time2, uint8 arenatype, uint8 uiframe)
1253	1253		{
1254	1254		    // we can be in 2 queues in same time...
1255	1255		
...			
1292	1292		            *data << uint32(bg->GetMapId());                // map id
1293	1293		            *data << uint32(Time1);                         // time to bg auto leave, 0 at bg start, 120000 after bg end, milliseconds
1294	1294		            *data << uint32(Time2);                         // time from bg start, milliseconds
1295		-	            *data << uint8(/*bg->isArena() ? 0 :*/ 1);      // unk, possibly 0 == preparation phase, 1 == battle
1295	+	            *data << uint8(uiframe);                    // unk, possibly 0 == preparation phase, 1 == battle
1296	1296		            break;
1297	1297		        default:
1298	1298		            sLog.outError("Unknown BG status!");



BattlegroundMgr.h

193	193		        void BuildGroupJoinedBattlegroundPacket(WorldPacket *data, BattleGroundTypeId bgTypeId);
194	194		        void BuildUpdateWorldStatePacket(WorldPacket *data, uint32 field, uint32 value);
195	195		        void BuildPvpLogDataPacket(WorldPacket *data, BattleGround *bg);
196		-	        void BuildBattleGroundStatusPacket(WorldPacket *data, BattleGround *bg, uint8 QueueSlot, uint8 StatusID, uint32 Time1, uint32 Time2, uint8 arenatype);
196	+	        void BuildBattleGroundStatusPacket(WorldPacket *data, BattleGround *bg, uint8 QueueSlot, uint8 StatusID, uint32 Time1, uint32 Time2, uint8 arenatype, uint8 uiframe = 1);
197	197		        void BuildPlaySoundPacket(WorldPacket *data, uint32 soundid);
198	198		        void SendAreaSpiritHealerQueryOpcode(Player *pl, BattleGround *bg, const uint64& guid);


Player.cpp

20223	20223		                if (!detect || !m_mover->canDetectStealthOf(u, GetDistance(u)))
20224	20224		                    return false;
20225	20225		    }
20226	+	
20227	+	    if (GetTypeId() == TYPEID_PLAYER && u->GetTypeId() == TYPEID_PLAYER)
20228	+	        if (HasAura(32727) || u->HasAura(32727))
20229	+	            if ((HasAura(32724) || HasAura(35774)) && (u->HasAura(32724) || u->HasAura(35774)))
20230	+	                return true;
20231	+	            else if ((HasAura(32725) || HasAura(35775)) && (u->HasAura(32725) || u->HasAura(35775)))
20232	+	                return true;
20233	+	            else
20234	+	                return false;
20226	20235		
20227	20236		    // If use this server will be too laggy
20228	20237		    // Now check is target visible with LoS

ni fix buat vanish the evading part

Spell.cpp

coba cari d part ini

// reset damage to 0 if target has Invisibility and isn't visible for caster
            // I do not think this is a correct way to fix it. Sanctuary effect should make all delayed spells invalid
            // for delayed spells ignore not visible explicit target
            if (m_spellInfo->speed > 0.0f && unit == m_targets.getUnitTarget()
                && (unit->m_invisibilityMask || m_caster->m_invisibilityMask)
                && !m_caster->canSeeOrDetect(unit, true))


ganti jadi 

// reset damage to 0 if target has Invisibility and isn't visible for caster
            // I do not think this is a correct way to fix it. Sanctuary effect should make all delayed spells invalid
            // for delayed spells ignore not visible explicit target
            if (m_spellInfo->speed > 0.0f && unit == m_targets.getUnitTarget()
                && ((unit->m_invisibilityMask || source->m_invisibilityMask) || unit->HasAuraTypeWithFamilyFlags(SPELL_AURA_MOD_STEALTH, SPELLFAMILY_ROGUE, SPELLFAMILYFLAG_ROGUE_VANISH))
                && !source->canSeeOrDetect(unit, true))

Itu code yang pertama kegabung ama baris dari github ya?
Jadi pusing ngeliatnya.
Kasi link nya aja bro.
Ga usa kasih diff nya, langsung aja kasih link nya biar gw langsung ke TKP.
Tenkyu brow.

ooh ok Thx kk..
ntar di cari lagi..
btw cara cari tw perbedaan nya gmna ya?

perbedaan utama dari mangos dan trinity diliat darimananya bang?jangan2 bnyk script yang gua coba sbnrnya di mangos lg..

Ni gw kasi contoh perbedaan struktur script Mangos ama Trinity.

MANGOS STRUCT
http://github.com/rsa/scriptdev2/raw..._lich_king.cpp

struct MANGOS_DLL_DECL boss_the_lich_king_iccAI : public BSWScriptedAI
{
    boss_the_lich_king_iccAI(Creature* pCreature) : BSWScriptedAI(pCreature)
    {
        pInstance = (instance_icecrown_spire*)pCreature->GetInstanceData();
        oldflag = 0;
        Reset();
    }

TRINITY STRUCT
http://bitbucket.org/bolvor/icecrown..._lich_king.cpp

struct boss_lich_kingAI : public ScriptedAI
{
	boss_lich_kingAI(Creature* pCreature) : ScriptedAI(pCreature), summons(me)
	{
		m_pInstance = pCreature->GetInstanceData();
		pLichKing = me;
	}

Untuk cara pengimporan dari Mangos -> Trinity sebenernya bisa dilakuin (buat newbie kek gw) dengan logika dan coba2.

Misalkan:
struct MANGOS_DLL_DECL boss_the_lich_king_iccAI : public BSWScriptedAI

tentunya MANGOS_DLL_DECL tu ga akan kebaca di trinity, karena memang ga dipanggil dari file *.h.
trus BSW di mangos itu kode untuk Boss Spell Worker, ada file header ama cpp nya kalo mangos.

berbeda kan dengan trinity,

struct boss_lich_kingAI : public ScriptedAI.


nah berarti kalo suatu saat ada pemanggilan struct dari mangos dengan bentukan "struct MANGOS_DLL_DECL <codename script mangos> : public BSWScriptedAI", agar bisa dibaca di trinity, diubah menjadi "struct <codename script trinity> : public ScriptedAI".
Itu cuma contoh doang.
Untuk yang selanjut lanjut lanjut lanjut lanjut lanjut nya, kudu banyak2 belajar bro.
Gw aja masih belum bisa ngimpor2 gituan, bisanya baru otodidak ngeliatin hasil orang doang. haha.

KEMBALI KE PERTANYAAN, gimana cara tau bedanya script mangos dan trinity?
1. Kalo di tes pasti error (pastinya..)
2. Perbedaan hanya bisa diliat oleh orang2 yang tentunya sudah berpengalaman (gw termasuk yang belum ). Dengan sering nyoba2, sering liat, sering ngebanding2in, mungkin malah bisa bkin script sendiri bro-bro sekalian (gw si males bkin script, ngerti aja kagak ).

klo misal script achieve leeroy ini gimana ?
dari ciri2 yg disebutin di atas gak ada sama skali - -a

Ini script trinity.
Kenapa?
Liat bagian yang #include nya.

#include "ScriptedPch.h"

Ciri panggilan buat script di trinity.
Sedangkan kalo mangos,

#include "precompiled.h"

Gitu brader..

BTW, script leeeeroy uda ga dibutuhin, soalnya kalo baca dari comment di trinity issues itu, katanya uda di pake di revisi keberapa gitu. Dan pas gw check juga scriptnya uda lebih update lagi. Jadi kalo masih belum jalan juga achievement leeeeroy, gw kurang tau dibagian mana yang salah. Mohon dimaklumi. Haha.


Btw, masih soal kelinglungan tentang script mangos or trinity. Tentunya script2 yang ada di forum trinity core, pasti itu adalah script trinity. Kalo misalkan itu adalah script mangos, pasti ada kata2 " please import this code to trinity ", ato permintaan pengimporan kode gitu. Itu sudah dipastikan script mangos yang disadur dari beberapa sumber, agar bisa di import oleh orang2 trinity.

[gaptekbet]

Itu code yang pertama kegabung ama baris dari github ya?
Jadi pusing ngeliatnya.
Kasi link nya aja bro.
Ga usa kasih diff nya, langsung aja kasih link nya biar gw langsung ke TKP.
Tenkyu brow.

Maksudnya itu kamu tinggal cari line di module cpp nya sesuain dengan line yg ada disitu, tanda + artinya penambahan baris baru, tanda - artinya menghapus baris.
Untuk beberapa kasus penambahan manual dengan mencari line tertentu dan ditambahkan/dikurangi sangat berguna mengingat jumlah baris belum tentu sama untuk beberapa modul cpp tergantung dari revisi core nya.

[heaven1st]

Maksudnya itu kamu tinggal cari line di module cpp nya sesuain dengan line yg ada disitu, tanda + artinya penambahan baris baru, tanda - artinya menghapus baris.
Untuk beberapa kasus penambahan manual dengan mencari line tertentu dan ditambahkan/dikurangi sangat berguna mengingat jumlah baris belum tentu sama untuk beberapa modul cpp tergantung dari revisi core nya.

maksud gw bkn itu om, itu juga gw ngerti. Tapi dia itu kopas langsung dari commit nya, jadi ada nomer2 disebelahnya.

426 426 for (BattleGroundPlayerMap::const_iterator itr = GetPlayers().begin(); itr != GetPlayers().end(); ++itr)
427 427 if (Player *plr = objmgr.GetPlayer(itr->first))
428 428 {
429 + // BG Status packet
430 + WorldPacket status;
431 + BattleGroundQueueTypeId bgQueueTypeId = BattleGroundMgr::

Kalo harus di delete 1 1 angka2 nya kan ribet. gitu lo.
Jadi kalau ntar ngambil dari situs semacam github, abis liat commit terbaru / ada perubahan, klik di kanan atas, "View file @ <revisi commit>", trus klik "raw". Jadi bentukannya lebih rapi.

Ni contoh gw ambil langsung dari github,

.. ... @@ -6,8 +6,8 @@ UPDATE `creature_template` SET `ScriptName`='boss_cyanigosa' WHERE `entry`='3113
6 6 UPDATE `creature_template` SET `ScriptName`='boss_erekem' WHERE `entry`='29315';
7 7 UPDATE `creature_template` SET `ScriptName`='mob_erekem_guard' WHERE `entry`='29395';
8 8 UPDATE `creature_template` SET `ScriptName`='boss_ichoron' WHERE `entry`='29313';
9 -UPDATE `creature_template` SET `ScriptName`='mob_ichor_globule',`modelid_A`=5492, `modelid_H`=5492 WHERE `entry`='29321';
10 -UPDATE `creature_template` SET `modelid_A`=5492, `modelid_H`=5492 WHERE `entry`='31515'; -- heroic
9 +UPDATE `creature_template` SET `ScriptName`='mob_ichor_globule',`modelid_1`=5492, `modelid_3`=5492 WHERE `entry`='29321';
10 +UPDATE `creature_template` SET `modelid_1`=5492, `modelid_3`=5492 WHERE `entry`='31515'; -- heroic
11 11 UPDATE `creature_template` SET `ScriptName`='boss_lavanthor' WHERE `entry`='29312';
12 12 UPDATE `creature_template` SET `ScriptName`='boss_moragg' WHERE `entry`='29316';
13 13 UPDATE `creature_template` SET `ScriptName`='boss_xevozz' WHERE `entry`='29266';

Ni kalo dari github -> view file -> raw

UPDATE `creature_template` SET `ScriptName`='boss_cyanigosa' WHERE `entry`='31134';
UPDATE `creature_template` SET `ScriptName`='boss_erekem' WHERE `entry`='29315';
UPDATE `creature_template` SET `ScriptName`='mob_erekem_guard' WHERE `entry`='29395';
UPDATE `creature_template` SET `ScriptName`='boss_ichoron' WHERE `entry`='29313';
UPDATE `creature_template` SET `ScriptName`='mob_ichor_globule',`modelid_1`=5492, `modelid_3`=5492 WHERE `entry`='29321';
UPDATE `creature_template` SET `modelid_1`=5492, `modelid_3`=5492 WHERE `entry`='31515'; -- heroic
UPDATE `creature_template` SET `ScriptName`='boss_lavanthor' WHERE `entry`='29312';
UPDATE `creature_template` SET `ScriptName`='boss_moragg' WHERE `entry`='29316';
UPDATE `creature_template` SET `ScriptName`='boss_xevozz' WHERE `entry`='29266';

Jadi lebih rapih n enak ngeliatnya gitu. Kalo mau ngasi code nya kesini bentukan raw, kalo misalkan males untuk ngubah jadi raw version, mending kasi linknya aja. Maksud gw gitu om.

[[A]sterix]

kk minta bantuannya donk buat fix glyph, hehe klo sempet di fix yah, soalnya gg itu glyph bagi para mage, mohon maaf klo dah di post sebelumnnya

Polymorph Glyph
ini keterangan dari wow head

Glyph of Polymorph
3 sec cast
Tools:
Virtuoso Inking Set
Reagents:
Ink of the Sea, Resilient Parchment

Glyph of Polymorph
Major Glyph
Classes: Mage
Requires Level 15
Item Level 13
Use: Your Polymorph spell also removes all damage over time effects from the target.
Sell Price: 1

sumber : http://www.wowhead.com/spell=56987

[BebeghTempoer]

has ada mendingnya maneh maen wow lagi aja.... biar bisa tau bug2nya... sekalian nemenin aing maen